Closed jennifer-richards closed 6 years ago
If these resulted in TID responses being sent back (even if the TID requests failed, which they should) these should not be counted as errors. The "tid_reqs_processed" counter should increase.
The "tid_error_count" is intended to count connections on the TID port that could not be completed - i.e., authentication failed or something went wrong in the TID processing. (Whether that's the most useful thing to count I'm not sure, but it is what we do.)
I see that I misread your test case, because I was expecting different behavior.
Would it be easy to add a separate entry for when the TR generates a TID error message?
Passed.
Whoops; I commented on the wrong issue here. Re-opening.
I was almost able to make it work in 10 minutes so I went ahead and put in the other 10 to wrap it up.
I've added a tid_reqs_failed
option that reports the number of TID requests that resulted in error messages being sent. Only successful requests are counted in tid_reqs_processed
now.
I'm not sure about the naming of the options any more - I'm having trouble coming up with short labels that clearly indicate what the categories mean. Right now it's "reqs_processed", "reqs_failed", and "error_count"
Same as before except Result C should now have the tid_reqs_failed
incrementing to count the invalid TID requests. That count should not increment for any of the other cases.
This was tested / passed
TID request / error counting
This tests that the TID request counting behaves correctly. It is assumed that the format of the monitoring response has already been tested.
For these tests, open two terminals - one for sending TID requests and the other for sending monitoring requests.
Steps
trmon <host> <port> show tid_reqs_processed tid_reqs_pending tid_error_count
(result A)Expected results
tid_reqs_processed
should be nonzero and match the number of successful request you made, others should be zero (if you executed the monitoring command immediately after the TID request, thetid_reqs_pending
may be nonzero, but should return to zero after no more than 10 seconds)tid_reqs_processed
should have increased by the number of requests you made,tid_err_count
should still be 0~ See "new test" below for Result Ctid_reqs_pending
should be 1tid_reqs_pending
should be 0 andtid_reqs_processed
should have incremented by 1tid_err_count
should match the number of invalid requests you made,tid_reqs_pending
should be 0, andtid_reqs_processed
should not have changed