painless-software / python-cli-test-helpers

Useful helpers for writing tests for your Python CLI program.
https://python-cli-test-helpers.readthedocs.io
GNU General Public License v3.0
30 stars 4 forks source link

Clarify conditional code for Python 2.7, remove license specifier #10

Closed bittner closed 2 years ago

bittner commented 2 years ago

We officially dropped support for Python 3.4 with commit 9e1b071, recently (mainly because we can't prove it anymore on GHA). The conditional code, though, is still needed for Python 2.7. This needs to be made clear in the code to avoid accidental removal.

The removal of the setup(license=) specifier is motivated by a suggestion from the Python Packaging docs:

The license argument doesn’t have to indicate the license under which your package is being released, although you may optionally do so if you want. If you’re using a standard, well-known license, then your main indication can and should be via the classifiers argument. Classifiers exist for all major open-source licenses.

The license argument is more typically used to indicate differences from well-known licenses, or to include your own, unique license.