painless-software / python-cli-test-helpers

Useful helpers for writing tests for your Python CLI program.
https://python-cli-test-helpers.readthedocs.io
GNU General Public License v3.0
28 stars 4 forks source link

Move git tag == version check to `tox.ini` #44

Closed bittner closed 1 year ago

bittner commented 1 year ago

This follows the idea of keeping the pipeline implementation as dumb as possible.

The change also removes a tricky complexity that is hard to investigate and troubleshoot: The version check requires that the package is installed, hence skip_install = true will break the environment. This was not immediately apparent with the original pipeline code, having the two sequential tox calls. The isolated execution of the two tasks/environments makes this more natural to understand.