search

paircolumbus / pairs

Find other people to pair with based on shared interests and skills.
http://pairs.meteor.com/
MIT License
4 stars 10 forks source link

Login dropdown goes off screen #64

Closed degoeym closed 9 years ago

degoeym commented 9 years ago

As seen in the screen capture bellow, the login menu goes off the right hand side of the screen. This should be corrected.

screen shot 2015-07-15 at 11 44 34 pm
degoeym commented 9 years ago

I'm pretty sure the sign in portion should be part of some kind of navbar. The reason is I had to add a bit of CSS to hide a bullet point that was next to the word admin, but if it were part of a bootstrap navbar that wouldn't be needed.

As you'll note in the documentation for Bootstrap's navbar, each button/dropdown on it is basically a li or ul, which means the css for the navbar is covering up the bullets that would be present.

http://getbootstrap.com/components/#navbar-default

Further, you'll note the dropdown on the far right in the above documentation pushes its dropdown item cleanly to the left so it's not cutoff on the right side of the browser window/viewport.

Also, note that in the documentation for the accounts ui item, all the example screenshots appear to be part of navbars.

https://github.com/ianmartorell/meteor-accounts-ui-bootstrap-3/

degoeym commented 9 years ago

Added a new navbar to the site layout. Colors may conflict a bit due to using the bootstrap-material-design package, but additional tweaks can be made. The main thing this fixes is the login dropdown going off the right side of the user's browser window.

degoeym commented 9 years ago

Moved the navbar to cover all of the top of the page, and used the appropriate bootstrap class for the nav item so it displays more correctly when clicked.

degoeym commented 9 years ago

Considering this fixed for now as the changes with the navbar were merged into main.