Closed dilomo closed 1 year ago
Will check the tests soon
Edit: I added some things but as I dont have idea what are these classes I might have done something wrong.
I made another push to the repo today. Can you check if its ok? Im not sure how to include the latest changes to show here. Should I make another pull request?
Hey, it is okay, I mean I see all your changes.
Regarding tests: you should be able to run them in your IDE, and see which one pass and which one not, it would be really nice to refactor them so they will pass, and add few of them to unit test also your part. If you need more info about it: let me know.
Graph Axis with colour range should be optional IMO
Point Annotation is OK
For some reason I still can't get the Scatter Data, can you add some example .gh file in repo so I could try it?
Regarding SVG: I'd say that if it is not that much reliable, then it is better to not add it at all. Later people will brag about that we should fix this or that.
Really nice icons! It 100% match existing ones.
Lets test and try to use for a week or two to figure out if everything is matching good? I have to make a series of graphs by 21t so will let you know how it is after that.
Hi!
Recently I'm constantly working on another project, that's why I'm not here all the time, but will try to keep in touch :)
- because you have only X,Y values, and still it shows you a color range for nothing
I don't understand what you mean. Are you seeing the colour axis even if you don't use the Scatter Data component? Can you show me an example gh file or image so that I know what you mean? Maybe if you use single colour as input instead of a list to define the palette the colour axis should be hidden.
- or just add separate compoenent, so if someone will need axises+range then he will use it
I think that's why I made the scatter data component to display that range. Maybe if the component name is Gradient Data it will make more sense? Next to axis you mean on the x or y axis? If so I'm not sure oxyplot supports having dual values on one axis?
- Regarding svg: I try to avoid hidden features ;)
That's ok.
I have tested it during last week and it works as expected but maybe the terminology and component name should be changed. I have updated the branch just now.
Hi, will check it out probably next week, and will let you know ;)
Hello, did you have any time recently to have a look at the latest updates? I fixed some of the annoyances and I think is usable with no problems.
Hey, great, I will probably have some time next week. Will let you know ;)
Added Scatter data for points with precise size and colour control and colour axis and annotation data to tag specific points + more control over title and legend.