search

pairofdocs / gomule-d2r

GoMule enabled for D2R
GNU Affero General Public License v3.0
59 stars 16 forks source link

expanded stash/inventory/cube size #15

Open stefaz opened 2 years ago

stefaz commented 2 years ago

Hi,

are there any plans to support non-standard stash/inv/cube sizes? some mods (e.g. https://github.com/cyhyraethz/d2r-basic-qol) are offering expanded sizes and I was wondering if gomule-d2r could support these. someone did this for an older gomule version here (https://d2mods.info/forum/viewtopic.php?t=62872), so it seems to be possible.

thanks!

pairofdocs commented 2 years ago

@stefaz That's possible, I dont want to support various sizes since that would need a different background image for each modded size

The code to support modded sizes of the cube or inventory is here https://github.com/pairofdocs/gomule-d2r/blob/1870f546c4f916fcd2a407af4ea553688601b673/gomule/src/gomule/gui/D2ViewChar.java#L63-L90

Kongolan commented 2 years ago

When using a mod like Expanded Storage (https://www.nexusmods.com/diablo2resurrected/mods/13?tab=description) it works well for the Character Inventories, since it doesn't overwrite what is there in the extra space. But when using the shared stash, it doesn't even load/open in GoMule once you put items out of "bounds".

Can you support that it still loads, while it just leaves those items there like for the normal Inventory.

Miao4382 commented 2 years ago

@pairofdocs Hi! I'm trying to figure out how to add support for expanded inventory and stash size. When I compile and run GoMule.main(), the version is "R0.43 Donkey", which is different from the current release (R0.44). Could you tell me where can I find the latest repo?

pairofdocs commented 2 years ago

Can you support that it still loads, while it just leaves those items there like for the normal Inventory.

Hey, no, I dont think I can support that feature here. I don't have the time that I had a few months ago.

pairofdocs commented 2 years ago

@pairofdocs Hi! I'm trying to figure out how to add support for expanded inventory and stash size. When I compile and run GoMule.main(), the version is "R0.43 Donkey", which is different from the current release (R0.44). Could you tell me where can I find the latest repo?

@Miao4382 I think R0.43 Donkey is okay for this repo (github/pairofdocs/gomule-d2r)

Silos has the official repo for golume on sourceforge (https://sourceforge.net/projects/gomule/files/). I forked gomule-d2r from the older code from source forge, that's why pairofdocs/gomule-d2r still has R0.43

both pairofdocs/gomule-d2r and Silos D2R Gomule work for D2R