Closed iansinnott closed 4 years ago
This is still a WIP but I want the tests to run, so it's no longer a "draft"
@iansinnott everything works on my phone with Chrome. It's still hard to navigate around the workspace but the code-mirror
editor works perfectly fine, as far as I can tell. And I can solve challenges, which means the rest of the functionality works. 👍
By the way, I think draft PRs will still run status checks, they don't have to be marked ready for review.
Awesome, thanks for checking.
I'm not sure what was happening earlier but the tests weren't running. the branch sat here for hours without any actions getting run. either that or I totally missed it, but I'm pretty used to the process now.
Anyway, i also thought it would run draft PRs. maybe something else happened here
Mobile experience on my phone is AWESOME 💯
code-mirror
looks and feels great.There are a few minor UI/UX issues, which can be easily addressed later:
z-index
overlap issues I noticed with the header and modals we display.But these are all pretty minor - just commenting them here to record them since I just noticed them all. Overall, the experience is really good and this definitely makes the app totally usable on mobile.
Really like Code Mirror!
Awesome! Glad it's working on your end too. Going to be really nice to stop redirecting people to a screen about how bad we are on mobile 😅
I agree about the minor things. There are still a few more touches I'd like to put on before merging, but generally we can iterate from here.
CM is pretty sweet. I really like one of the auto-close plugins. It's great on mobile to have tags close themselves out without having to type symbols.
More changes:
LGTM 👍
Checked it out on my phone again. A few more comments, but nothing major to take action on. Overall really cool! I like the updates.
0 of N Completed
tends to be off the right side of the screen, along with the expand/collapse control. We could probably try to truncate these or render various elements differently on mobile.Good points.
I made some stylistic updates, especially to the nav menu. Will merge if tests pass and we can iterate from there
ICodeEditor
) which will be used to standardize the code editing lib. Monaco and CodeMirror will both adhere to this interface while the implementations details can be lib specific.