pairwise-tech / pairwise

The Pairwise Codebase
https://app.pairwise.tech
6 stars 0 forks source link

React Native Web! #208

Closed bonham000 closed 4 years ago

bonham000 commented 4 years ago

This PR:

Notes:

Demo:

[1]: The React Native MVP Challenge:

Screen Shot 2020-07-21 at 3 51 13 PM

[2]: The Workspace has an alternative default UI before the tests are first run:

Screen Shot 2020-07-21 at 3 33 18 PM
iansinnott commented 4 years ago

What do you think about rewriting react-native-web to react-native in the user code the way codesandbox does?

iansinnott commented 4 years ago
* Should we change the build settings and minify the `react-native-web-lib.js` file? I'm not sure.

Hm, good question. How large is it? I'm thinking maybe we just leave it unminified if it provides better stack traces and the only visible downside is the loading time.

bonham000 commented 4 years ago

I think we should go with renaming it to react-native, I think this is the general approach using react-native-web anyways. I'll update the code to reflect this.

Also, agree on using the un-minified version for (hopefully) better stack traces. This was also my same reasoning for including the development builds of React and ReactDOM. So I'll leave that the way it is now.

bonham000 commented 4 years ago

@iansinnott just tagging you in case you want to review the replies I added above. I'll merge this in a bit later.

iansinnott commented 4 years ago

Awesome, thanks for putting this together