Closed bonham000 closed 4 years ago
What do you think about rewriting react-native-web
to react-native
in the user code the way codesandbox does?
* Should we change the build settings and minify the `react-native-web-lib.js` file? I'm not sure.
Hm, good question. How large is it? I'm thinking maybe we just leave it unminified if it provides better stack traces and the only visible downside is the loading time.
I think we should go with renaming it to react-native
, I think this is the general approach using react-native-web
anyways. I'll update the code to reflect this.
Also, agree on using the un-minified version for (hopefully) better stack traces. This was also my same reasoning for including the development builds of React and ReactDOM. So I'll leave that the way it is now.
@iansinnott just tagging you in case you want to review the replies I added above. I'll merge this in a bit later.
Awesome, thanks for putting this together
This PR:
react-native-web
. We are building it with Webpack via this repo and copying the source file into the Workspace codebase. Any updates would require the file to be re-built.loop-protect
issue in production build closing #42.lastActiveChallengeIds
(discovered it from our tests 😎).Notes:
react-native-web-lib.js
file? I'm not sure.Demo:
[1]: The React Native MVP Challenge:
[2]: The Workspace has an alternative default UI before the tests are first run: