search

paissaheavyindustries / Triggernometry

Triggernometry is a plugin for Advanced Combat Tracker, intended to extend its built-in trigger system with a variety of different actions and configuration options.
MIT License
253 stars 48 forks source link

Revert of previous pull request with build script kept #105

Closed FreedomFaighter closed 2 months ago

FreedomFaighter commented 3 months ago

Create build-plugin.yml

Revert "websocketsharp as nuget package"

This reverts commit f937ec1c53b727d374e6434acfbeeb194de02e6b.

websocketsharp as nuget package

readded websocketsharp loose files

updated project file with relative path to Program Files x86 directory

readded mathparser

Create build-plugin-and-release-on-tag.yml

removed mathparser for the package from nuget

added websocket-sharp package

removed files brought in by package

paissaheavyindustries commented 2 months ago

Thanks for the PR! However, there is a reason why WebsocketSharp is not used as a package, and Triggernometry tries to use as few packages as possible. ACT loads assemblies only once, and the version that gets loaded depends on which plugin gets loaded first. That can cause ACT to load a version of an assembly which may conflict with other ACT plugins if they happen to reference other versions, and that can cause assembly version hell.

FreedomFaighter commented 2 months ago

WebsocketSharp is also a repository have you considered submoduling the same version that align on the commit information that is custom to your plugin

paissaheavyindustries commented 2 months ago

Yeah that's probably a good idea, will look into it