paissaheavyindustries / Triggernometry

Triggernometry is a plugin for Advanced Combat Tracker, intended to extend its built-in trigger system with a variety of different actions and configuration options.
MIT License
253 stars 48 forks source link

Text aura refresh rate has been reduced #59

Closed AkilaeTribe closed 2 years ago

AkilaeTribe commented 3 years ago

Context

Text auras have a property "Text to display" that can contain a string expression. As the variables used in the expression change values over time, so does the displayed text.

The issue

The refresh rate of the displayed text in Triggernometry version 1.1.4.1 is now much slower; around one update per second. It used to be higher (multiple updates per second) in older versions, allowing displays of highly volatile variables in real-time (like a player position).

The trigger to reproduce the issue

<?xml version="1.0"?>
<TriggernometryExport Version="1">
  <ExportedTrigger Enabled="true" Name="Position-Show" Id="ed2ab636-16be-4beb-9e48-f7445c0fe0ea" RegularExpression="position-show" PrevActions="Interrupt">
    <Actions>
      <Action OrderNumber="1" LogLevel="-1" TextAuraAlignment="MiddleLeft" TextAuraFontSize="15.75" TextAuraForeground="White" TextAuraBackground="Black" TextAuraName="PositionText" TextAuraExpression="Position: (x: ${numeric:round(${_ffxivparty[${_ffxivplayer}].x}, 1)}, y: ${numeric:round(${_ffxivparty[${_ffxivplayer}].y}, 1)})" TextAuraXIniExpression="1539" TextAuraYIniExpression="386" TextAuraWIniExpression="319" TextAuraHIniExpression="42" TextAuraOIniExpression="100" TextAuraFontName="Microsoft Sans Serif" ActionType="TextAura" Description="Position: (x: ${numeric:round(${_ffxivparty[${_ffxivplayer}].x}, 2)}, y: ${numeric:round(${_ffxivparty[${_ffxivplayer}].y}, 2)})&#xD;&#xA;&#xD;&#xA;${numeric:round(&#xD;&#xA;, 2)}">
        <Condition Enabled="false" Grouping="Or" />
      </Action>
    </Actions>
    <Condition Enabled="false" Grouping="Or" />
  </ExportedTrigger>
</TriggernometryExport>
paissaheavyindustries commented 2 years ago

It hasn't been changed, but depending on your GPU load it might start lagging. You might experience this under heavy loads.