search

paissaheavyindustries / Triggernometry

Triggernometry is a plugin for Advanced Combat Tracker, intended to extend its built-in trigger system with a variety of different actions and configuration options.
MIT License
253 stars 48 forks source link

A random bug about ${_ffxivparty} #71

Open MnFeN opened 2 years ago

MnFeN commented 2 years ago

Hi,

I found my triggers sometimes do not work properly. After debugging, it showed that ${_ffxivparty[a party member's name].role} randomly returns empty value, instead of "DPS", "Tank" or "Healer".

This trigger is expected to be executed in P2 Sanctity (Dragonsong) to identify the two meteor players, and I am sure that other parts were not written wrong.

Thanks.

KingPendragoon commented 2 years ago

To back this up It isn't just role related. ${_ffxivparty[1].name} will sometimes return null. I have gotten a lot of people asking for help on why my triggers works for 7 of the party members but the 8th will randomly break. They report it was working a previous day and not the next. The solution I have to give them is to hardcode the names. Issue has been reported to me by people using both XIV Quick Launcher as well as vanilla game.

MnFeN commented 2 years ago

Me too, I also found it later. Now I have to save a list of player names and jobs before the battle to make sure the triggers work properly.

Edit: It seems that _ffxiventity does not have this bug. I am using _ffxiventity instead of _ffxivparty in most cases now. (except for those related with party order)

Lighitng commented 1 year ago

I met this issue as well. (Plugin Version: 1.1.6.0) However I was trying to read _ffxivparty[i].id, it had been working until Dragonsong P5, but after we went into next phase, there were suddenly a few empty objects in _ffxivparty, I cannot read any id except myself and one of my teammates. (I write a debugger to take snapshot of party state) Not sure why it changed during one battle, I was thinking it is injected at the begining of each battle. Then it crashed some of my triggers hah.