paissaheavyindustries / Triggernometry

Triggernometry is a plugin for Advanced Combat Tracker, intended to extend its built-in trigger system with a variety of different actions and configuration options.

MIT License

253 stars 48 forks source link

Persistent Variable "FloppyDisk" resets to off in some actions when you edit/view them #72

Closed FrUct1s closed 2 years ago

FrUct1s commented 2 years ago

Hard to explain. I'll try.

Whenever you Edit/open the action "Generic JSON operation" the persistent variable "FloppyDisk" icon resets to off/grey.

Same with "Scalar variable operation" -> "Query variable with JSONPath and store list value". although it retains the FloppyDisk on "Scalar variable name" but it loses/resets it on "Target variable name". persistentvariable

FrUct1s commented 2 years ago

I just realisied you don't even need to open the action.

As soon as you open the trigger without touching any of the actions with persisent variables and save the trigger they still reset to off.

Makar8000 commented 2 years ago

73 will fix this particular issue. Were there any other instances where the action settings get reset, or was it just this specific persist ("floppy disk") status for "Target variable name"?

FrUct1s commented 2 years ago

I noticed it on following two actions and only this setting with the floppy disk:

"Generic JSON operation" "Scalar variable operation" -> "Query variable with JSONPath and store list value". although it retains the FloppyDisk on "Scalar variable name" but it loses/resets it on "Target variable name".

Thank you for checking

Makar8000 commented 2 years ago

Updated the PR to include the fix for Generic JSON operation as well