Fix outdated exec script translation

paissaheavyindustries / Triggernometry

Triggernometry is a plugin for Advanced Combat Tracker, intended to extend its built-in trigger system with a variety of different actions and configuration options.

MIT License

253 stars 48 forks source link

Fix outdated exec script translation #84

Closed sandtechnology closed 1 year ago

sandtechnology commented 1 year ago

It will cause error when using exec script action Related code: https://github.com/paissaheavyindustries/Triggernometry/blob/6de49d67d31249b267c05175b8d64cb1617443c4/Source/Triggernometry/Action.cs#L565-L567 https://github.com/paissaheavyindustries/Triggernometry/blob/6a87dc8d0c5bdb6d0115060b93646f50c5f2dbd5/Source/Triggernometry/I18n.cs#L74-L91

Makar8000 commented 1 year ago

It looks like you are pulling these changes from the wrong fork, as there are several changes to files that probably should not be merged (ex. gitignore and ACT reference location). I suggest only making a PR for the triglations file, and if there's a reason for keeping all of the other changes you should probably explain it.

sandtechnology commented 1 year ago

oh it just an wrong changes since I use this branch in other PRs accidentally, I will fix it by opening a new PR