paissaheavyindustries / Triggernometry

Triggernometry is a plugin for Advanced Combat Tracker, intended to extend its built-in trigger system with a variety of different actions and configuration options.
MIT License
253 stars 48 forks source link

The regex "rexfunc" for the separation of "${func:name:string}" does not tolerate with parenthesis #92

Closed MnFeN closed 10 months ago

MnFeN commented 1 year ago

https://github.com/paissaheavyindustries/Triggernometry/blob/6de49d67d31249b267c05175b8d64cb1617443c4/Source/Triggernometry/Context.cs#L34

https://github.com/paissaheavyindustries/Triggernometry/blob/6de49d67d31249b267c05175b8d64cb1617443c4/Source/Triggernometry/Context.cs#L853-L869

${func:name:string}

When name is a function with no parenthesis and string contains parenthesis, the regex rexfunc would not separate the expression correctly and get blank / wrong result.

e.g. ${func:trim: (1) } should give (1) ${func:length:(3+5)*2} should give 7

MnFeN commented 10 months ago

Fixed in #98