Closed cakoose closed 5 years ago
[Edit: fixed the details of which functions accept null and which ones don't.]
In node-sodium
crypto_generichash
null
crypto_generichash_init
crypto_generichash_blake2b
crypto_generichash_blake2b_init
In the underlying libsodium, the docs say that you can pass a null key: https://libsodium.gitbook.io/doc/hashing/generic_hashing
Is it ok to change node-sodium's and crypto_generichash_init and crypto_generichash_blake2b_init to accept a null key as well?
[Edit: fixed the details of which functions accept null and which ones don't.]
In node-sodium
crypto_generichash
(source) allows anull
keycrypto_generichash_init
(source) does notcrypto_generichash_blake2b
(source)crypto_generichash_blake2b_init
(source) does notIn the underlying libsodium, the docs say that you can pass a null key: https://libsodium.gitbook.io/doc/hashing/generic_hashing
Is it ok to change node-sodium's and
crypto_generichash_init
andcrypto_generichash_blake2b_init
to accept anull
key as well?