search

pajaydev / ebay-node-api

eBay API Client for node
https://pajaydev.github.io/ebay-node-api
MIT License
132 stars 76 forks source link

New Feature : Please provide an Example to list an item #10

Open sm-a opened 6 years ago

sm-a commented 6 years ago

You have an excellent API with also excellent examples. Please provide also an example of how to use a "post request" to "list an item".

Since I have no idea how this works and others will certainly be happy about an example.

Thank you, Sven

TotallyNotChase commented 4 years ago

Looks like the listing api isn't implemented yet. I would like to take this on and see how far I go.

I believe this is the api that should be implemented. I'm thinking about having a function for the listing itself, essentially the user passes the Request payload, which contains information about the listing, and the function adds that payload as well as the oauth token that's already in options to make a request.

pajaydev commented 4 years ago

@TotallyNotChase Thanks. Yes, you can integrate that API, which use to create a draft listing in eBay.

TotallyNotChase commented 4 years ago

@pajaydev Hi! Currently working on both implementing the listing API and also creating some plans for some potential cleanup. I can finally start working full force now since I got my ebay dev account approved.

I just wanted to ask, in getAccessToken, where the user is able to pass in scopes as part of the scope parameter, are those parameters encoded? According to this guide, there's a pretty specific way for the scopes to be structured. I didn't notice a function that does this though but I may have missed it. Could you let me know if there is a functionality for this?

pajaydev commented 4 years ago

@TotallyNotChase That's Awesome. I think we have to do something like this https://github.com/eBay/ebay-oauth-nodejs-client/blob/901f8a2769293332953c9073bee20f6e07323369/src/index.js#L59

I am thinking to integrate with this library to get Access tokens. Kindly let me know if you want to do this. I can quickly make this change. Thanks

TotallyNotChase commented 4 years ago

@pajaydev that's precisely it. Should just join the user provided array with a space and URLencode the whole thing.

pajaydev commented 4 years ago

@TotallyNotChase Cool. I have created this issue to integrate with eBay auth module.

https://github.com/pajaydev/ebay-node-api/issues/93

Let me know how fast u need this. easy fix is simply copying those lines and include in our library.

TotallyNotChase commented 4 years ago

@pajaydev all good, no rush specifically for that. Quick question though, it seems we don't have a authorization_code flow set up. Looks like the ebay api will want the user consent code before giving a authorization_code, client credential workflow works fine but I suggest we implement the user consent functionality.

I could work on that before implementing the whole selling API, as we seem to be needing this sooner. I could implement the scope functionality along the way as well.