pajaydev / ebay-node-api

eBay API Client for node
https://pajaydev.github.io/ebay-node-api
MIT License
132 stars 75 forks source link

findCompletedItems deprecation #125

Closed zslabs closed 3 years ago

zslabs commented 3 years ago

👋 @pajaydev

Due to the recent announcement that the findCompletedItems endpoint will be deprecated without the Market Insights API, I wanted to see if you had any thoughts on if adding support for itemFilters in findItemsAdvanced https://developer.ebay.com/DevZone/finding/CallRef/findItemsAdvanced.html would be possible, so we could pass through the SellingState https://developer.ebay.com/devzone/finding/callref/findItemsAdvanced.html#Response.searchResult.item.sellingStatus.sellingState

pajaydev commented 3 years ago

@zslabs Thanks for reporting this. yes, sure we can add support in itemsFilters. Free feel to do this change if you want to take this up or I will do.

zslabs commented 3 years ago

Thanks for the quick response! I noticed that the constructAdditionalParams function you have should technically take care of this, but what I'm a bit confused about is how we'd have both sellingStatus and sellingState as it's a sub-property of this item filter. If you do end up having a few to look at this, I'd really appreciate it. Thanks as always!

zslabs commented 3 years ago

Hm, even though I'm seeing SoldItemsOnly on https://developer.ebay.com/DevZone/finding/CallRef/types/ItemFilterType.html (as I thought sellingState might be available), it is marked as "future" and I'm not getting any results using that in the API playground.

If you have any thoughts, we might need to get a bit creative here unfortunately :(

Some more discussion https://forums.developer.ebay.com/questions/37466/findcompleteditems-dropped-from-finding-api.html

pajaydev commented 3 years ago

@zslabs Thanks for looking into this. Let me take a look and get back to you.

zslabs commented 3 years ago

Until eBay either adds the endpoint back (unlikely) or enables the sold filter on the advanced search, it doesn't look like there's an option here.