search

pajaydev / ebay-node-api

eBay API Client for node
https://pajaydev.github.io/ebay-node-api
MIT License
132 stars 75 forks source link

plan to update npm package? #153

Closed rambonette closed 2 years ago

rambonette commented 2 years ago

Issue or Enhancement

Steps to reproduce

Hi @pajaydev :) ! Currently is not possible to search by epid code using searchItems() with 'ebay-node-api' npm package, but code in this repo allows it. Are you planning to update the npm package?

Expected Behavior

Normal expectation is to be able to search by epid using the npm package

Actual Behavior

find { offset: 0, epid: '21023325241' } Error: Error --> Keyword or category id is required in query param at Ebay.searchItems (/root/node_modules/ebay-node-api/src/buy-api.js:52:88)

pajaydev commented 2 years ago

Thanks for bringing this up. Published a new version ebay-node-api@2.9.0

rambonette commented 2 years ago

Thank you! Have a nice one ;)

rambonette commented 2 years ago

Hi @pajaydev ! Hope you're doing well :)

Seems like, although npm version has been bumped, searchItems function in buy-api.js is still the old one! As a matter of fact, I still get the old error log:

UnhandledPromiseRejectionWarning: Error: Error --> Keyword orcategory id is required in query param

Should be this instead (according to latest commit):

Error --> Kindly provide the valid Keyword, category id, epid or gtin in query param

Let me know! Take care ;)

rambonette commented 2 years ago

nm turns out i was using and old version :')