search

pajaydev / ebay-node-api

eBay API Client for node
https://pajaydev.github.io/ebay-node-api
MIT License
131 stars 76 forks source link

Finding api improvements #57

Closed piggydoughnut closed 5 years ago

piggydoughnut commented 5 years ago

Goal of the pull request:

Description

fidItemsByKeywords accepts parameters now - keywords, pageNumber, limit, sortOrder. It still supports passing just one keyword.

Will highly appreciate if you update the npm package if all is good.

piggydoughnut commented 5 years ago

Hey :) Thank you for your merge! Please re-publish the npm package when you have a moment. 🤗

pajaydev commented 5 years ago

@piggydoughnut Sorry for the delay. Published it in ebay-node-api@2.7.1

zslabs commented 5 years ago

Seeing regressions with this release - a single keyword ...findItemsByKeywords(term)... throws Keyword is missing, Keyword is required

2.7.0 works as expected, but 2.7.1 has the issue.

pajaydev commented 5 years ago

@zslabs From this version, we have changed Keyword to Keywords. Do you want me to use keyword ?.

zslabs commented 5 years ago

@pajaydev Thanks for the response - I may not have worded by question correctly, but using the example from README:

//This call searches for items on eBay by a keyword query (keywords).
ebay.findItemsByKeywords('iphone').then((data) => {
    console.log(data);
}, (error) => {
    console.log(error);
});

Throws an error now for me. This is the exact code that worked previously in 2.7.0 - does the README need to be updated?

pajaydev commented 5 years ago

@zslabs Gotcha. Fixed it in ebay-node-api@2.7.2. Sorry for the inconvinence

zslabs commented 5 years ago

@pajaydev Thanks for the quick-fix! All's well again. Have a great day.