pajlads / DinkPlugin

Sends level up, clue, etc. notifications to a Discord webhook or a custom web server
https://runelite.net/plugin-hub/show/dink
BSD 2-Clause "Simplified" License
40 stars 17 forks source link

Loot notifier at Nex screenshots before chat message shows up #402

Open emiljensen2 opened 10 months ago

emiljensen2 commented 10 months ago

Checklist

Describe your issue

When receiving a drop at nex the screenshot will have the item on the ground, but not in the chat. The chat message is like delayed by a 1 tick, or the way nex rolls loot delays the message so it doesn't appear on instant screenshots. Perhaps it is possible to delay the screenshot at nex

Screenshots

image

Runelite Logs

not in log

Runelite Version

1.10.18.2

iProdigy commented 9 months ago

we should audit all of these NPCs for this "issue": https://github.com/runelite/runelite/blob/a8b8c3f2f6bec14bf1c383859013613e6526927f/runelite-client/src/main/java/net/runelite/client/game/LootManager.java#L343-L443

umer-rs commented 4 months ago

from what I can tell, nex and nm have this issue. the chat message for uniques is delayed by 1 game tick.

https://github.com/umer-rs/google-form-submitter/commit/1ead65214316630b2c220ac999aced6567362b57

badookey commented 4 months ago

perhaps worth a separate issue/feature request, but something that would solve this could be a 'screenshot after x' configuration option. This could delay the screenshot for however many seconds/ticks and send to the webhook afterwards.

Personally I'd want this featur to capture clan loot broadcasts/reactions, while still sending an image in the rough area that the event happened.