search

pajlads / DinkPlugin

Sends level up, clue, etc. notifications to a Discord webhook or a custom web server
https://runelite.net/plugin-hub/show/dink
BSD 2-Clause "Simplified" License
40 stars 15 forks source link

Report button inconsistency #409

Open emiljensen2 opened 10 months ago

emiljensen2 commented 10 months ago

Checklist

Describe your issue

When dink takes a screenshot of events it doesn't always show the date despite it being enabled in the base screenshot plugin. I'm not quite sure what causes it Collection log events seem to always have the date show if popup is enabled, I see some cases of date not showing and they don't have the popup enabled. CA events also seem to capture date consistently (Though this is without the popup, so unsure if it's always true) Levels, loot, kill count, quests is inconsistent from what I've seen.

Sorry for yet another report

Screenshots

image image

Runelite Logs

shouldn't be relevant

Runelite Version

1.10.19

pajlada commented 10 months ago

Could you compare these with the screenshots that were saved on disk (and maybe post them too)?

emiljensen2 commented 10 months ago

I've taken some levels screenshots since my rl doesn't do loot itself. image Runecraft(84) 2024-01-16_22-24-18 image Mining(91) 2024-01-10_19-21-35 The mining screenshot is interesting, they appear to be taken a little time apart as my idle notification is visible on the dink screenshot, but not the local screenshot. Though ig it's also visibly different for the zeah screenshot.

pajlada commented 10 months ago

We delay certain notifiers, sometimes to make sure we get all level ups that happened, sometimes to give time for the loot to appear in the chat or on the ground for the screenshot.

I suspect this is just a matter of us not using the screenshot plugin, but just happen to be taking screenshots at the same time as the screenshot plugin for certain events.

I guess it boils down to more of a feature request: Should we replicate the screenshot plugin's "Report button" functionality?

emiljensen2 commented 10 months ago

Ah that makes sense, I thought at first you were using the screenshot plugin's functionality so to speak. but that makes sense. So it's inconsistent because it sometimes captures on the same frame/tick(?), but it is not intended.

Yeah I guess it'd be a feature request then.

iProdigy commented 10 months ago

Yeah we would have to replicate https://github.com/runelite/runelite/blob/master/runelite-client/src/main/java/net/runelite/client/plugins/screenshot/ScreenshotOverlay.java to implement this feature

Felanbird commented 9 months ago

The current upstream implementation of the report button does not respect where the report button actually is, if the chat box is somewhere else, it will just float in it's normal spot. Keep that in mind whether or not we want to fix it ourselves, fix it for them, or wait for someone to fix it.

Discussed in the discord last week but I don't believe anyone bothered to open an issue.