pajlads / DinkPlugin

Sends level up, clue, etc. notifications to a Discord webhook or a custom web server
https://runelite.net/plugin-hub/show/dink
BSD 2-Clause "Simplified" License
36 stars 14 forks source link

Webhooks are delayed + profiles disappear #521

Closed Yoface640 closed 1 month ago

Yoface640 commented 1 month ago

Checklist

Describe your issue

When dying or getting a drop, webhooks are delayed and the profile tab disappears until the webhook is actually sent at which point they reeappar. Other people sending to the same webhook do not have this issue. Problem does not occur when Dink is off.

Screenshots

profilestabafterdeath image image

Runelite Logs

client.log

Runelite Version

1.10.36.1

pajlada commented 1 month ago

It looks to me like the network request times out, how this would do anything with the profiles page is beyond me though. Maybe unrelated to Dink but related to the NullPointerException further up in the logs? iProdigy might have a better idea

iProdigy commented 1 month ago

In Dink's advanced settings, what is your Image Upload Timeout set to? Also what's your upload speed? the error suggests a network issue rather than a dink bug (but you could reduce the Screenshot Scale if your network is weak so less data needs to be uploaded)

Yoface640 commented 1 month ago

30s, it does go away sometimes and when using a vpn to play goes away completely. Don't mind the delay just don't want it affecting my other plugins such as !pb or !layout in COX. Upload speed is image

Felanbird commented 1 month ago

Can you type ::dinkexport all into the in-game chat, Go to :wrench: -> 👥 -> click new profile - double-click to swap to that new profile, Download dink again, ::dinkimport into chat and see if your issue persists?

and when using a vpn to play goes away completely

While testing those steps may show that it's a conflict with another plugin, the fact that your issue goes away with a VPN enabled makes me personally think that it's an internet problem, unrelated to a fast speedtest result.

Yoface640 commented 1 month ago

Yes, issue still occurs on a new profile with only dink enabled.

iProdigy commented 1 month ago

I'll have to check runelite's usage of the shared ScheduledExecutorService

For diagnosing the network issue, would be useful to run WinMTR pointed at discord.com (let us know how many hops & whether there's packet loss - dont upload the full output here as it can reveal your IP)

iProdigy commented 1 month ago

runelite's ProfilePanel does make heavy use of the shared ScheduledExecutorService

dink's http requests are also performed on the same executor, so when your network times-out, it's possible for profile panel actions to be delayed

since your internet is fast, you could reduce the image upload timeout to 10s, so the profile panel loads faster when your internet does have some transient timeout issue