pajlads / DinkPlugin

Sends level up, clue, etc. notifications to a Discord webhook or a custom web server
https://runelite.net/plugin-hub/show/dink
BSD 2-Clause "Simplified" License
40 stars 15 forks source link

Boss kill count messages send inconsistent image #577

Closed harbingerofme closed 1 week ago

harbingerofme commented 2 weeks ago

Checklist

Describe your issue

When hitting an interval, randomly an image of the boss will be attached to the message. This does not always get attached, nor is there a way to not send these at all. The size of them is inconsistent as well across different bosses.

Screenshots

Screenshot 2024-10-28 124838 Screenshot 2024-10-28 124931

Runelite Logs

client.log

Runelite Version

1.10.42.1

Felanbird commented 2 weeks ago

Is there an icon in the top right of the first notif? I assume it's discord falling back because the first embed we intend to send is not being sent, and it's falling back to the second one, coming from the wiki link to Kraken.

Maybe you can also try changing %BOSS% in your notification message to <%BOSS%>? That would work in theory since <link_here> is how you send a link on discord without embed.

iProdigy commented 2 weeks ago

The boss image is automatically added as a rich embed if you disabled screenshots (and a matching NPC with the given name could be found): https://github.com/pajlads/DinkPlugin/blob/v1.10.12/src/main/java/dinkplugin/notifiers/KillCountNotifier.java#L155 (we will debate outright disabling this behavior or adding a setting toggle for it)

This image is sourced from the wiki, and they use much larger images for NPCs relative to item images (which we use for collection log and pet notification thumbnails)

harbingerofme commented 2 weeks ago

Is there an icon in the top right of the first notif? I assume it's discord falling back because the first embed we intend to send is not being sent, and it's falling back to the second one, coming from the wiki link to Kraken.

Yes, that one is normal.

Maybe you can also try changing %BOSS% in your notification message to <%BOSS%>? That would work in theory since <link_here> is how you send a link on discord without embed.

For the record, the message previously was %COUNT% **%BOSS%**!. Adding brackets completely breaks it. Screenshot 2024-10-28 221713

harbingerofme commented 2 weeks ago

Full relevant config

image

Felanbird commented 2 weeks ago

For the record, the message previously was %COUNT% **%BOSS%**!. Adding brackets completely breaks it.

heh