pajoma / vscode-journal

Lightweight journal and simple notes support for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=pajoma.vscode-journal
GNU General Public License v3.0
230 stars 40 forks source link

vscode-journal overriding theme syntax highlighting #44

Open GISmd opened 5 years ago

GISmd commented 5 years ago

Info

Details

I'm experiencing some odd changes in syntax highlighting when vscode-journal is enabled, especially with checkbox lists. Most hyphens (not all) become yellow and and incomplete checkboxe brackets are yellow. This makes them very difficult to see when using a light colored theme.

These changes persist regardless of what theme I am using. Examples below.

Normal syntax highlighting

syntax-vscode-journal

Syntax highlighting with vscode-journal

syntax-normal

pajoma commented 5 years ago

Most hyphens (not all) become yellow and and incomplete checkboxe brackets are yellow. I guess this affects all indented checkbox items, which are not covered by the regular expressions used for syntax highlighting.

This makes them very difficult to see when using a light colored theme. The syntax highlighting rules are inserted in your user settings. During startup, the extensions checks if the settings are present and adds them if not. If you switch from a dark to a light color mode, you have to update the colors manually. It's a bit complicated, I know, but another solution (using decorators) seems to be too much of an overhead for such a small feature.

How to adapt the settings: Switch to the user settings and find the section "editor.tokenColorCustomizations". You can either change the colors or remove the following rules for the following scopes: