search

pajoma / vscode-journal

Lightweight journal and simple notes support for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=pajoma.vscode-journal
GNU General Public License v3.0
233 stars 40 forks source link

File link not present in entry error when using Journal: New Journal Note command #97

Closed dtomlinson91 closed 2 years ago

dtomlinson91 commented 2 years ago

Whenever I use the Journal: New Journal Note command to add a note under the current day, it repeatedly adds all the notes to the journal entry for that day. The command really cannot be used as it quickly becomes a mess.

This also happens whenever I try to create a new journal note.

When pressing CMD+SHIFT+J and creating a new note, no entry is added to the journal page for the note under it.

When I press the same command and go to todays entry it inserts the links for every single file.

Whenever I go to todays entry using this command, it will duplicate all notes under that day.

A video demo of the issue: https://imgur.com/a/HGCCyns

Output of the console: https://gist.github.com/dtomlinson91/ae669c056e3168156b754b97ebd96bda

MatrixRanger98 commented 2 years ago

I am having this issue, too. Something went wrong after the latest update.

MatrixRanger98 commented 2 years ago

I used Journal: New Journal Note command but no link is created. What is even more curious: From then on every time I use New Journal Memo/Task/Note, the same link (which does not appear as wanted in the first attempt) is added over and over again.

fpopineau commented 2 years ago

I get this problem too.

pajoma commented 2 years ago

I know. Issue is already fixed in current dev branch, I am struggling to find time for testing.

fpopineau commented 2 years ago

I gave it a try and recompile from the current sources. I can confirm that the multiple entries issue is gone AFAICS.

kdenhartog commented 2 years ago

@fpopineau which branch did you build off of for this? Also, @pajoma what sort of additional testing are you looking for to ship this feature? It looks like it's just testing the work added in this commit is that correct? Depending on the amount of work it would take I'm open to helping to finish up the testing on this issue for you. Otherwise I'm also open to making a donation to see this fix get shipped.

This is the one bug that I want to fix to make this my permanent note taking tool. The extension is awesome for what I need and happy to help.

fpopineau commented 2 years ago

@kdenhartog I just build from develop branch. I can't confirm right now if the commit you cite is the only one involved.

pajoma commented 2 years ago

A new milestone release has been added which addresses this bug. Can you please test (download it here) and verify?

kdenhartog commented 2 years ago

I can confirm this worked as expected for me! If you add a sponsor button to your GH account or some other means I'd be happy to make a donation to you for finishing this up. I know maintaining open source code can be daunting at times and really appreciate you getting this journal to this point so far. It's minimal but at the same time does exactly everything I need from it and keeps it in VS Code so I don't have to go far when I want to jot something down.

pajoma commented 2 years ago

Thanks for the test and confirmation. And many thanks for the donation ;)

Closing this, has been fixed for 1.0.0