remove default profile fields; fix minor typo

paked / messenger

Package messenger is used for making bots for use with Facebook messenger

MIT License

274 stars 72 forks source link

Closed OAyomide closed 5 years ago

OAyomide commented 5 years ago

This is the PR to fix #50

OAyomide commented 5 years ago

Hey! Thanks!

I do understand your point. I'll revert those and make the PR again. :upside_down_face:

pranas commented 5 years ago

I have concerns about this change, see here.

OAyomide commented 5 years ago

@pranas @paked can you review please? I made the changes as discussed in #50

If all is well, perhaps I could go ahead and fix the example(s) :upside_down_face:

OAyomide commented 5 years ago

@paked sorry for the never-ending commits! :see_no_evil: I didn't realize the example would make the build fail.

paked commented 5 years ago

Okay, wow. I think that was the last review. After those changes we should be good to merge.

OAyomide commented 5 years ago

Got it @paked

I'll jump on it and make the changes promptly.

paked commented 5 years ago

Thanks for sticking with me through the twisty turn-y path we used to get to this point!

If you're looking for another issue to work on, #55 would be great.