search

paked / messenger

Package messenger is used for making bots for use with Facebook messenger
MIT License
274 stars 72 forks source link

Logrus logger instead of fmt.Println #67

Closed jBugman closed 5 years ago

jBugman commented 5 years ago

This is the most opinionated one, so I'm not really expecting it be merged. It brings some pretty heavy dependencies with Logrus (instead of for example std logger) to allow users easy customization or opting out of currently mandatory stdout-no-format logging.

paked commented 5 years ago

This is adds dependencies without a decent justification, is too opinionated, and IMO we should probably not have logging in this package anyway (bar perhaps debug mode) (my philosophy is usually that logging should be managed by the user of the library, we just need to provide them with the info to log [via errors]).

Sorry, going to close. Logrus seems like a cool package though. Thanks for bringing it to my attention!

jBugman commented 5 years ago

Yes, my point was that there should not be implicit logging, thats why in our fork we went with the explicit and user controlled one. I too vote for errors of some kind, but at first glance it seems like a big API change.