pakerfeldt / android-viewflow

A horizontal view scroller library for Android
1.78k stars 694 forks source link

viewflow-example: not all buttons seen #2

Closed tilusnet closed 13 years ago

tilusnet commented 13 years ago

Hi! I was curious about your library, so I tried it on my device (HTC Desire, Froyo OS) by running the viewflow-example: on your screenshot all buttons from 0 to 9 are shown, whereas on mine only 0 to 6. I am going to make a screenshot for you.

tilusnet

tilusnet commented 13 years ago

Screenshot: http://tilusnet.com/tmp/gfx/viewflow-example-notallseen.png

pakerfeldt commented 13 years ago

Alright, so there is something odd with the main.xml layout in the example. The buttons are only for convenience though and shouldn't effect the actual library. What if you flip orientation?

tilusnet commented 13 years ago

True, it's not related to the library, I just thought I let you know. (although the app crashed the first time I flicked beyond number 9, but never since) In landscape orientation there's enough space for all buttons.

pakerfeldt commented 13 years ago

Yes, thanks for the report. I will try to have this fixed in the future.

The crash experience is interesting as well. If you ever manage to reproduce the FC, please report it. I'm very keen on making the library stable.

pakerfeldt commented 13 years ago

Closing this since I've just merged the pull request from Eric that introduces a new kind of nice flow indicator.