builder toml rfc - Githubissues

paketo-buildpacks / builder

Apache License 2.0

12 stars 6 forks source link

builder toml rfc #36

Closed joshzarrabi closed 4 years ago

joshzarrabi commented 4 years ago

RFC to implement #27

Readable: https://github.com/joshzarrabi/builder/blob/builder-toml-rfc/rfcs/0002-buildpack-toml-versioning.md

Co-authored-by: Sophie Wigmore swigmore@vmware.com

sophiewigmore commented 4 years ago

@ForestEckhardt @sclevine @nebhale tagging you in this PR since I'm not able to add a reviewer

ForestEckhardt commented 4 years ago

@joshzarrabi Could you add a readable link to the initial post please?

ForestEckhardt commented 4 years ago

@joshzarrabi I only have feed back on readability. If you could move your alternative implementations into a different section that would make this more readable. Other than that I approve.

joshzarrabi commented 4 years ago

@nebhale I added the note about the lifecycle and builder, thanks for pointing that out :)

nebhale commented 4 years ago

@joshzarrabi Approved over here. Merge and implement at will.