paketo-buildpacks / dep-server

Apache License 2.0
3 stars 11 forks source link

Failed to Build/Upload tini #254

Closed github-actions[bot] closed 1 year ago

github-actions[bot] commented 1 year ago

Build and Upload workflow failed to run. Please take a look to ensure the version in the workflow is built and uploaded successfully. (cc @paketo-buildpacks/dependencies-maintainers)

sophiewigmore commented 1 year ago

Failures related to building an old version (0.3.2) of tini, which shouldn't have been built (we currently support 0.19.0). Closing this out!

github-actions[bot] commented 1 year ago

Another failure occurred: https://github.com/paketo-buildpacks/dep-server/actions/runs/3691450357

robdimsdale commented 1 year ago

This looks like an issue with tini itself:

Scanning dependencies of target tini
[ 50%] Building C object CMakeFiles/tini.dir/src/tini.c.o
/github/workspace/source/krallin-tini-73aabc2/src/tini.c: In function 'print_usage':
Error: /github/workspace/source/krallin-tini-73aabc2/src/tini.c:57:80: error: expected expression before ')' token
  fprintf(file, "%s (version %s - %s)\n", basename(name), TINI_VERSION, TINI_GIT);
                                                                                ^

I'm not familiar enough with tini to know why this is happening. However, I believe we are moving towards pre-compiled, externally-hosted tini binaries (e.g. this RFC) which would result in avoiding this compilation failure entirely.

Given that, I'm going to close this issue as we are unlikely to spend time investigating why this is happening and how to resolve it.