This PR changes the behavior of the action that updates the go toolchain version to also update the go version in addition to updating the toolchain version. This is necessary because some of our dependencies have higher versions of go than we do and in order to keep them up to date we must also bump to the minimum version of go that they have. Rather than trying to identify the lowest-common-denominator across all dependencies it is easier to always use the latest version.
If we wanted to ensure that we did not need the latest version of go, we could choose to not bump these dependencies. But I think we should keep our dependencies up to date and accept the golang bump. Especially because most of our products are binaries and not libraries, and hence we can control the version of golang they are built with.
I opted to keep the toolchain directive even though it's probably no longer necessary because I felt like being explicit is probably better than relying on the default behavior, given how confusing this situation is for all of us.
This PR changes the behavior of the action that updates the go toolchain version to also update the
goversion in addition to updating thetoolchainversion. This is necessary because some of our dependencies have higher versions of go than we do and in order to keep them up to date we must also bump to the minimum version of go that they have. Rather than trying to identify the lowest-common-denominator across all dependencies it is easier to always use the latest version.If we wanted to ensure that we did not need the latest version of go, we could choose to not bump these dependencies. But I think we should keep our dependencies up to date and accept the golang bump. Especially because most of our products are binaries and not libraries, and hence we can control the version of golang they are built with.
See this conversation for more details.
I opted to keep the
toolchaindirective even though it's probably no longer necessary because I felt like being explicit is probably better than relying on the default behavior, given how confusing this situation is for all of us.