paketo-buildpacks / health-checker

A Cloud Native Buildpack that provides a health check binary compatible with Docker health checks
Apache License 2.0
6 stars 0 forks source link

Do not contribute a process type, but instead print commands in buildpack output #134

Closed dmikusa closed 1 week ago

dmikusa commented 1 month ago

Expected Behavior

Presently, we contribute a process type /cnb/process/health-check for convenience so it's easy to run the health check.

Current Behavior

When using the process type to run the health check this has the side effect of running exec.d helpers, because it runs the launcher. The initial thought was that this would be very fast and not a problem, but it seems like this isn't always true, see #87.

It is also possible that this could trigger unwanted behavior, because any buildpack can contribute an exec.d helper so a custom buildpack could contribute one that is only intended to run once, yet this could cause it to be run many times.

Possible Solution

Steps to Reproduce

See #87

Motivations

See #87