Do not add debug options if already available in JAVA_TOOL_OPTIONS

paketo-buildpacks / libjvm

A library and helper applications that form the basis for building the different Paketo-style JVM-providing buildpacks

Apache License 2.0

19 stars 20 forks source link

Do not add debug options if already available in JAVA_TOOL_OPTIONS #280

Closed c0d1ngm0nk3y closed 1 year ago

c0d1ngm0nk3y commented 1 year ago

fixes #274

Summary

If the java agent is already configured via JAVA_TOOL_OPTIONS, it is not added a second time since this would cause an error when starting the java process.

Use Cases

see issue

Checklist

[X] I have viewed, signed, and submitted the Contributor License Agreement.
[X] I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
[ ] I have added an integration test, if necessary.
[X] I have reviewed the styleguide for guidance on my code quality.
[X] I'm happy with the commit history on this PR (I have rebased/squashed as needed).

linux-foundation-easycla[bot] commented 1 year ago

:white_check_mark: login: c0d1ngm0nk3y / name: Ralf Pannemans (7188912dcc42af1de3acd0e9490d0559aeb84380, 7188912dcc42af1de3acd0e9490d0559aeb84380)
:white_check_mark: login: modulo11 / name: Johannes Dillmann (7188912dcc42af1de3acd0e9490d0559aeb84380)
:x: The commit (7188912dcc42af1de3acd0e9490d0559aeb84380). This user is missing the User's ID, preventing the EasyCLA check. Consult GitHub Help to resolve.For further assistance with EasyCLA, please submit a support request ticket.

dmikusa commented 1 year ago

Ignore EasyCLA for now. It seems to have lost its mind. Hopefully, that will be resolved soon.

dmikusa commented 1 year ago

/easycla

dmikusa commented 1 year ago

Thanks!

c0d1ngm0nk3y commented 1 year ago

@dmikusa Any idea when the next release is made? We are waiting for this change...

dmikusa commented 1 year ago

Sorry, I'll cut a release now. In the future, ping me or David and we can get stuff like this going more quickly.

It won't make it into the composites this week, but we can probably get the SAP Machine buildpack updated this week. I suspect that's the one you care about most?