paketo-buildpacks / libpak

An opinionated extension to the libcnb Cloud Native Buildpack Library
Apache License 2.0
15 stars 18 forks source link

Do not check DeprecationDate when comparing dependencies #240

Closed c0d1ngm0nk3y closed 1 year ago

c0d1ngm0nk3y commented 1 year ago

Summary

This might be an alternative to #233 in addressing short comings when comes to comparing the metadata of a dependency.

Use Cases

As discussed in #233, comparing the metadata of a dependency is probably not needed at all if sha256 is the same. But at least the comparison should be successful in those cases since the dependency caching currently depends on it.

Checklist

modulo11 commented 1 year ago

This looks like a cost-efficient and compatible alternative until #233 can be continued on a v2 branch. @dmikusa is there anything holding us back from merging it?