paketo-buildpacks / libpak

An opinionated extension to the libcnb Cloud Native Buildpack Library
Apache License 2.0
15 stars 17 forks source link

Revert "adds logic to remove http query params from destination file name" #290

Closed pivotal-david-osullivan closed 11 months ago

pivotal-david-osullivan commented 11 months ago

Reverts paketo-buildpacks/libpak#273

A bug was discovered as a result of this change, wrt caching & offline buildpacks - when restoring dependencies from the cache, the dependency URI is used and not the URI SHA.

Given the potential to break apps on rebuild, this PR proposes reverting the change - it could be implemented for v2 of Libpak via #287

We will cut a new libpak and release new component buildpacks based on this - the composites have not yet been released with #273.