Handles deprecationDate in time.Time format in actual layer metadata - Githubissues

paketo-buildpacks / libpak

An opinionated extension to the libcnb Cloud Native Buildpack Library

Apache License 2.0

15 stars 18 forks source link

Handles deprecationDate in time.Time format in actual layer metadata #304

Closed jpastoor closed 9 months ago

jpastoor commented 9 months ago

Summary

Prevents panic as described in issue https://github.com/paketo-buildpacks/libpak/issues/269. After the change https://github.com/paketo-buildpacks/libpak/pull/261/files the Equals method became prone to panics due to the unchecked type assertions. This change makes the Equals method more robust, by not panicking when the deprecationDate is present in the layer metadata in an unexpected format.

Use Cases

Handling various LayerMetadata from without breaking whenever it does not exactly conform to expections.

Checklist

[x] I have viewed, signed, and submitted the Contributor License Agreement.
[x] I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
[x] I have added an integration test, if necessary.
[x] I have reviewed the styleguide for guidance on my code quality.
[x] I'm happy with the commit history on this PR (I have rebased/squashed as needed).

linux-foundation-easycla[bot] commented 9 months ago

The committers listed above are authorized under a signed CLA.

:white_check_mark: login: jpastoor / name: Joost Pastoor (d134fc42529071b5c3490273d3cf8b0e82b340cd, 9e4edd1ebcaf1194a50d98c9024705443d098c2b)
:white_check_mark: login: dmikusa / name: Daniel Mikusa (7c5ecafe7351bdeee74e751d0f046c3d93c2a9e7)