Allow hostname specific dependency mirrors

bitgully commented 4 months ago

Summary

Enhances the use of dependency mirrors introduced in #315. Changes have been applied according to the conversation in https://github.com/paketo-buildpacks/rfcs/pull/302 (Readable).

This change allows for setting separate mirror locations for each hostname in the dependencies' original URIs. A default mirror can still be used for all other dependencies.

Use Cases

This is required in networks where not all dependencies should be pulled from the same mirror location.

Checklist

[x] I have viewed, signed, and submitted the Contributor License Agreement.
[x] I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
[x] I have added an integration test, if necessary.
[x] I have reviewed the styleguide for guidance on my code quality.
[x] I'm happy with the commit history on this PR (I have rebased/squashed as needed).

dmikusa commented 4 months ago

Thanks for this PR. I added some thoughts/questions. Let me know what you think.

bitgully commented 4 months ago

@dmikusa Would you agree with my responses or do you think this needs more attention? Any specific ideas how we should go about adding this to packit?

loewenstein commented 4 months ago

Any specific ideas how we should go about adding this to packit?

I think that is already in progress with https://github.com/paketo-buildpacks/packit/pull/563

dmikusa commented 4 months ago

Sorry for the delay. I think this is looking good. Just one last question for you.

Thanks again for your work on this!

paketo-buildpacks / libpak