Closed pbusko closed 1 month ago
I don't feel like we should pull in a dependency on github.com/kobayashi/eol. It's a 0.1.0 release and hasn't been updated in over a year (last commit). It doesn't show strong signs of life. If I'm missing something there please let me know.
It may be a little more work, but there are only three API calls for the API itself, https://endoflife.date/docs/api. Do you have any objections to just making HTTP calls directly to the API? You could add a client under the internal
package, so we don't need to worry about exporting that as public, it'll be just for the library.
Aside from that, 👍 I like the idea. Automating metadata information is great.
It's a 0.1.0 release and hasn't been updated in over a year (last commit)
good point, I've moved the implementation to the internal package
@dmikusa We call the API directly instead of using the additional dependency like you proposed in this comment. Maybe you can have another look.
@dmikusa is there anything else blocking the PR from being merged?
Summary
Automatically populate
deprecation_date
for dependenciesUse Cases
This change adds the
--eol-id
flag to theupdate-buildpack-dependencies
cmd. When the flag is set, the product the EOL date is looked up for a product (the--eol-id
flag), formatted and added to thedeprecation_date
field.Checklist