Closed anthonydahanne closed 1 year ago
@dmikusa hey there 👋 I'm wondering about 2 things:
golang.org/x/exp
- if you're not comfortable with this, let me know, I'll refactorI've just set minor version upgrade; even though I have removed some deprecated flags - let me know if I have to remove the deprecation removal commit of if it should be major bump
I think we've removed settings before after deprecating them for a long period of time in minor versions. If you could separate this into its own PR, then we can wait till @pivotal-david-osullivan is back and double-check with him.
I've imported a golang.org/x/exp - if you're not comfortable with this, let me know, I'll refactor
slices.Contains
🤯 I can't understand why this isn't in the go stdlib
I'm pretty sure there are at least a couple of buildpacks or modules that have implemented "Contains". I have always intended to put that into libpak, but haven't had the time. That would be my preference, if we added a slices module we could put a common Contains in there. I can understand if you would rather just implement contains here. I'm fine with that as well.
I'm not necessarily adverse to a 3rd party library if there is perhaps another one, but what I don't like about this particular one is a.) that it's listed as experimental b.) it's kind of a grab bag with all sorts of functionality some totally unrelated, I'd prefer something that's specific to just slices or at least collections c.) there's no 1.0 release.
Hello @dmikusa ! Thanks for your comments!
slices
package to this PR (that copies the 2 needed functions for x/exp); meanwhile I've created an issue in libpak to create such slices
package in it, https://github.com/paketo-buildpacks/libpak/issues/238Yes, I forgot some tests; should be good now! please let me know!
Summary
Usage:
Checklist