Remove deprecated arguments

paketo-buildpacks / native-image

A Cloud Native Buildpack that creates native images from Java applications

Apache License 2.0

49 stars 9 forks source link

Remove deprecated arguments #256

Open anthonydahanne opened 1 year ago

anthonydahanne commented 1 year ago

BP_BOOT_NATIVE_IMAGE_BUILD_ARGUMENTS and BP_BOOT_NATIVE_IMAGE

They've been deprecated for 2 years now

Checklist

[x] I have viewed, signed, and submitted the Contributor License Agreement.
[x] I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
[x] I have added an integration test, if necessary.
[x] I have reviewed the styleguide for guidance on my code quality.
[x] I'm happy with the commit history on this PR (I have rebased/squashed as needed).

dmikusa commented 1 year ago

I think this looks good.

@pivotal-david-osullivan I wanted to confirm with you on this? Major or minor change? I think technically we're supposed to use major with removals, but this has also been deprecated for 2 years. We could stick with major and just hold this until we're ready for another major release? It's not urgent to merge this.

Thoughts?

pivotal-david-osullivan commented 1 year ago

I think that we should stick to convention and go with major, especially given it's not urgent to get it merged. So yes, once we have enough for a new major we can pull this in 👍