By allowing Open(at)InRoot to opt-out of the extra work done by MkdirAll
to do the necessary "partial lookups", Open(at)InRoot now does less work
for both implementations (resulting in a many-fold decrease in the number of
operations for openat2, and a modest improvement for non-openat2) and is
far more guaranteed to match the correct openat2(RESOLVE_IN_ROOT)
behaviour.
We now use readlinkat(fd, "") where possible. For Open(at)InRoot this
effectively just means that we no longer risk getting spurious errors during
rename races. However, for our hardened procfs handler, this in theory should
prevent mount attacks from tricking us when doing magic-link readlinks (even
when using the unsafe host /proc handle). Unfortunately Reopen is still
potentially vulnerable to those kinds of somewhat-esoteric attacks.
Several improvements were made to the errors returned by Open(at)InRoot and
MkdirAll when dealing with invalid paths under the emulated (ie.
non-openat2) implementation. Previously, some paths would return the wrong
error (ENOENT when the last component was a non-directory), and other paths
would be returned as though they were acceptable (trailing-slash components
after a non-directory would be ignored by Open(at)InRoot).
These changes were done to match openat2's behaviour and purely is a
consistency fix (most users are going to be using openat2 anyway).
However, it does introduce a new *os.File-based API which is much safer
to use for most usecases. These are adapted from [libpathrs][1] and are
the bare minimum to be able to operate more safely on an untrusted
rootfs where an attacker has write access (something that SecureJoin
cannot protect against). The new APIs are:
OpenInRoot, which resolves a path inside a rootfs and returns an
*os.File handle to the path. Note that the file handle returned by
OpenInRoot is an O_PATH handle, which cannot be used for reading or
writing (as well as some other operations -- see open(2) for more
details).
Reopen, which takes an O_PATH file handle and safely re-opens it to
"upgrade" it to a regular handle.
By allowing Open(at)InRoot to opt-out of the extra work done by MkdirAll
to do the necessary "partial lookups", Open(at)InRoot now does less work
for both implementations (resulting in a many-fold decrease in the number of
operations for openat2, and a modest improvement for non-openat2) and is
far more guaranteed to match the correct openat2(RESOLVE_IN_ROOT)
behaviour.
We now use readlinkat(fd, "") where possible. For Open(at)InRoot this
effectively just means that we no longer risk getting spurious errors during
rename races. However, for our hardened procfs handler, this in theory should
prevent mount attacks from tricking us when doing magic-link readlinks (even
when using the unsafe host /proc handle). Unfortunately Reopen is still
potentially vulnerable to those kinds of somewhat-esoteric attacks.
Several improvements were made to the errors returned by Open(at)InRoot and
MkdirAll when dealing with invalid paths under the emulated (ie.
non-openat2) implementation. Previously, some paths would return the wrong
error (ENOENT when the last component was a non-directory), and other paths
would be returned as though they were acceptable (trailing-slash components
after a non-directory would be ignored by Open(at)InRoot).
These changes were done to match openat2's behaviour and purely is a
consistency fix (most users are going to be using openat2 anyway).
[0.3.0] - 2024-07-11
Added
A new set of *os.File-based APIs have been added. These are adapted from
[libpathrs][] and we strongly suggest using them if possible (as they provide
far more protection against attacks than SecureJoin):
Open(at)InRoot resolves a path inside a rootfs and returns an *os.File
handle to the path. Note that the handle returned is an O_PATH handle,
which cannot be used for reading or writing (as well as some other
operations -- [see open(2) for more details][open.2])
Reopen takes an O_PATH file handle and safely re-opens it to upgrade
it to a regular handle. This can also be used with non-O_PATH handles,
but O_PATH is the most obvious application.
MkdirAll is an implementation of os.MkdirAll that is safe to use to
Add MountedFast by @kolyshkin in moby/sys#100
Note: most users should keep using Mounted, which already incorporates all optimizations from MountedFast
Bumps the go-modules group with 18 updates in the / directory:
1.5.51.5.60.0.0-20220526054621-78278af1949d0.0.10.0.150.0.161.33.11.34.12.14.02.14.20.5.40.5.52.17.02.18.00.7.00.8.01.0.01.0.10.12.40.12.50.2.50.3.10.5.00.6.00.1.00.3.01.2.21.3.01.6.01.7.00.52.00.53.00.16.00.17.01.64.11.65.0Updates
github.com/DataDog/zstdfrom 1.5.5 to 1.5.6Release notes
Sourced from github.com/DataDog/zstd's releases.
Commits
b52f603Merge pull request #143 from DataDog/viq111/1.5.6cf4778eUpdate Readme for 1.5.6ed87d43Update vendored zstd to 1.5.6dd7b332Merge pull request #136 from colinlyguo/fix-readmebeb4dfdMerge pull request #141 from DataDog/sfluor-patch-1e75a26aUpdate upperBound ratio when guessing the required decompression buffer sizec9a5141fix readme869dae0Merge pull request #132 from DataDog/viq111/bulk-fix-highlycompressed-payloadsbf7b920[bulk] Add extra empty payload decompression test9c0d33f[bulk] Fix namingUpdates
github.com/Netflix/go-envfrom 0.0.0-20220526054621-78278af1949d to 0.0.1Release notes
Sourced from github.com/Netflix/go-env's releases.
Commits
Updates
github.com/mattn/go-runewidthfrom 0.0.15 to 0.0.16Commits
6ceadc6Support Unicode 15.1.0Updates
github.com/onsi/gomegafrom 1.33.1 to 1.34.1Release notes
Sourced from github.com/onsi/gomega's releases.
Changelog
Sourced from github.com/onsi/gomega's changelog.
Commits
fa057b8v1.34.15e71dcdUse slices from exp/slices to keep golang 1.20 compat32e5498v1.34.0cb3fa6arun go mod tidy and wonder why go get doesnt just run it for me in the first ...8af2ecebump ginkgo878940cfix incorrect handling of nil slices in HaveExactElements (fixes #771)f5bec80clean up bipartitegraph testsebadb67issue_765 - fixed bug in Hopcroft-Karp algorithm123a071Fix typo in docsc549e0dAdd RoundTripper method to ghttp.ServerUpdates
github.com/paketo-buildpacks/packit/v2from 2.14.0 to 2.14.2Release notes
Sourced from github.com/paketo-buildpacks/packit/v2's releases.
Commits
3bc586edo not run draft release workflow on branches named v2-<something>d558b87Bump github.com/onsi/gomega from 1.33.1 to 1.34.19f2a7b3Bump github.com/gabriel-vasile/mimetype from 1.4.4 to 1.4.5b117031Updating github-configb6530bcInclude error handling7222905Fix override of existing values in prepend & appende366827Updating github-configa8ac405Bump github.com/gabriel-vasile/mimetype from 1.4.3 to 1.4.44ff7347Bump github.com/BurntSushi/toml from 1.3.2 to 1.4.0Updates
github.com/spdx/tools-golangfrom 0.5.4 to 0.5.5Release notes
Sourced from github.com/spdx/tools-golang's releases.
Commits
9db247bfix: provide a clearer error when using an invalid originator (#246)57d4b8efix: panic if JSON relationship array contains null (#239)606f188chore: update makefile to include bootstrap and go mod tidy (#243)282609efix: properly normalize Windows paths (#242)Updates
github.com/sylabs/sif/v2from 2.17.0 to 2.18.0Release notes
Sourced from github.com/sylabs/sif/v2's releases.
Commits
a2a8352Merge pull request #374 from tri-adam/delete-objects68683b4feat: add DeleteObjects94b0b65build(deps): bump github.com/google/go-containerregistry (#376)48f265fMerge pull request #373 from tri-adam/compactione8dad67refactor: improve delete compaction logic8783e3brefactor: improve compaction logic for AddObjecte3aa617Merge pull request #375 from tri-adam/update-readme8f557d5docs: update links to Go docsde30604Merge pull request #368 from tri-adam/go-1.23-rc9ea2328ci: add testing against Go 1.23 RCUpdates
golang.org/x/cryptofrom 0.24.0 to 0.25.0Commits
9fadb0bgo.mod: update golang.org/x dependenciesa6a393fall: bump go.mod version and drop compatibility shims1c74500ssh/test: make struct comment match struct named4e7c9cssh: fail client auth immediately on receiving disconnect messageUpdates
golang.org/x/netfrom 0.26.0 to 0.27.0Commits
e2310aego.mod: update golang.org/x dependencies77708f7quic: skip tests which depend on unimplemented UDP functions on Plan 99617c63http2: avoid Transport hang with Connection: close and AllowHTTPUpdates
golang.org/x/syncfrom 0.7.0 to 0.8.0Commits
411f99eLICENSE: update per Google LegalUpdates
golang.org/x/sysfrom 0.21.0 to 0.22.0Commits
faed7ecunix: add PthreadChdir and PthreadFchdir on darwinc892bb7unix: fix MmapPtr test failing on OpenBSDa0ef40aunix: fix MremapPtr test failing on NetBSDdaa2394unix: add unsafe mmap, munmap, mremap7670087windows: add GetAce Windows API348425awindows/svc: do not pass theService to windows.RegisterServiceCtrlHandlerExUpdates
dario.cat/mergofrom 1.0.0 to 1.0.1Release notes
Sourced from dario.cat/mergo's releases.
Commits
59ea6a9Merge pull request #251 from joshkaplinsky/joshkaplinsky/without-dereference-...96f24afMerge pull request #253 from vsemichev/master2f1a615fixes issue #187. adds test to verify the fix.4da170bfixes issue #187. attempt #3a13a117fixes issue #187. attempt #26b830fffixes issue #187f33862aWithoutDereference should respect structscde9f0eMerge pull request #246 from darccio/darccio/v1-frozenf1e2fe5chore: frozen v17f7b4afUpdate FUNDING.ymlUpdates
github.com/Microsoft/hcsshimfrom 0.12.4 to 0.12.5Release notes
Sourced from github.com/Microsoft/hcsshim's releases.
Commits
e970943Modifying network flag EnableIov.4f77a09Hcsshim wrapper over HNS API needed for exclusion of management mac addresses...3b5bd8a[release/0.12] vendor: github.com/containerd/containerd v17.1840cdbc8Adding state attribute to the HNSEndpoint struct to support hyperv containers...Updates
github.com/cyphar/filepath-securejoinfrom 0.2.5 to 0.3.1Release notes
Sourced from github.com/cyphar/filepath-securejoin's releases.
... (truncated)
Changelog
Sourced from github.com/cyphar/filepath-securejoin's changelog.
... (truncated)
Commits
ce7b28aVERSION: release v0.3.1a2c14f8CHANGELOG: add readlinkat(fd, "") shout-out4ea279fmerge #22 into cyphar/filepath-securejoin:main16e1becCHANGELOG: add initial changelog with current history2404ffbmerge #21 into cyphar/filepath-securejoin:mainf29b7a4lookup: handle // and trailing slash components correctlyecd61camerge #19 into cyphar/filepath-securejoin:main38b1220procfs: refactor statx mnt_id logic45c4415procfs: use readlink(fd, "") for magic-linksedab538merge #17 into cyphar/filepath-securejoin:mainUpdates
github.com/gabriel-vasile/mimetypefrom 1.4.4 to 1.4.5Release notes
Sourced from github.com/gabriel-vasile/mimetype's releases.
Commits
b36b70fremove exe from testdata (#561)e802551Bump the github-actions group across 1 directory with 3 updates (#560)f003e99Bump golang.org/x/net in the gomod group across 1 directory (#552)e0c5c59reduce project size by moving mimetype.gif to testdata (#548)f296c1balias rtf to application/rtf (#547)8329892Updating RTF Magic number to match <https://www.iana.org/assignments/media-ty...3267116remove tarbomb from testdata folder (#540)cdceff9zip: use []byte instead of string to prevent allocs (#537)77e3848tar: remove strconv dependency for tar checksum octal numbers (#536)09ff708json: improve performance by using a pool of scanners (#535)Updates
github.com/google/go-containerregistryfrom 0.19.2 to 0.20.0Release notes
Sourced from github.com/google/go-containerregistry's releases.
Commits
d36047aRestore blind-write to remote.Put (#1970)9915a85Referrer API must return correct Content-Type (#1968)Updates
github.com/moby/sys/sequentialfrom 0.5.0 to 0.6.0Release notes
Sourced from github.com/moby/sys/sequential's releases.
Commits
03b9f8dMerge pull request #94 from thaJeztah/bump_mountinfobdd898emount: update github.com/moby/sys/mountinfo v0.5.0fbd276cMerge pull request #93 from kolyshkin/ci-f35afb7f50Merge pull request #92 from kolyshkin/more-linters9372d68ci: bump Fedora to 359a90d6dFormat code with gofumpt, enable linter85e4bfdMakefile: update golangci-lint to 1.43.0f0fb439.gitattributes: addb016007ci: add unconvert and errorlint linters to golanci6056970Fix errorlint warningsUpdates
github.com/moby/sys/userfrom 0.1.0 to 0.3.0Release notes
Sourced from github.com/moby/sys/user's releases.