search

paketo-buildpacks / node-engine

A Cloud Native Buildpack for Node
Apache License 2.0
23 stars 26 forks source link

Compile dependency on actual stack images #585

Open sophiewigmore opened 1 year ago

sophiewigmore commented 1 year ago

The dependency that this buildpack provides is compiled on an image that isn't actually the stack image. This could result in subtle bugs - like features not being enabled or enabled features not being available at run-time - due to differences in configuration and available libraries. We should compile the dependency on the actual stack base image rather than a similar image.

pacostas commented 2 days ago

The compilation is failing on the CI, because python version is the wrong version. Fixing this issue will also fix the failure on the CI as the image that node is being compiled will be the correct one with the corect python version.