search

paketo-buildpacks / nodejs

A Cloud Native Buildpack for Node.JS
Apache License 2.0
57 stars 20 forks source link

Updates buildpacks in buildpack.toml #844

Closed paketo-bot closed 3 months ago

pacostas commented 7 months ago

This PR upgrades the datatog from 3 to 5. This is a major change, I think a closer look should be taken on this one if everything still works fine (for the datadog).

hany commented 5 months ago

Is there any chance this PR will be merged soon?

mhdawson commented 4 months ago

Looks like this test is still failing - --- FAIL: TestIntegration/Integration/NodeStart/when_building_a_node_app_that_does_not_use_a_package_manager/when_using_optional_utility_buildpacks/should_build_a_working_OCI_image_and_run_the_app_with_the_start_command_from_the_Procfile_and_other_utility_buildpacks (35.38s)

mhdawson commented 4 months ago

The failing test seems to be related to the new version of DataDog - to contain lines <[]interface {} | len:1, cap:1>: [ <matchers.ContainSubstringMatcher | 0xc0003bcbd0>{ Substr: "Buildpack for Datadog", Args: nil, }, ] but missing <[]interface {} | len:1, cap:1>: [ <matchers.ContainSubstringMatcher | 0xc0003bcbd0>{ Substr: "Buildpack for Datadog", Args: nil, }, ]

mhdawson commented 4 months ago

I reverted the update to Datadog and we'll see if the tests pass without that.

mhdawson commented 4 months ago

In fixing the breakage in some of the other buildpacks I marked them as SemVer major, I think we should wait for those new versions released (which I think happens once a week). This PR should then be updated with the new versions and it should be good to land with the update to DataDog reverted.

sophiewigmore commented 4 months ago

Hey @paketo-buildpacks/nodejs-maintainers - I was wondering if was possible for y'all to push this through? I just saw an issue about this here - https://github.com/orgs/paketo-buildpacks/discussions/299

mhdawson commented 3 months ago

Release published