paketo-buildpacks / nodejs

A Cloud Native Buildpack for Node.JS
Apache License 2.0
55 stars 21 forks source link

Node change to 3.0.1 causes embedded daemon response: max depth exceeded] #894

Open pbrumm opened 1 month ago

pbrumm commented 1 month ago

rolling back to node 3.0.0 and node-engine@4.1.1 has fixed the issue.

not sure why the latest shows node going to 3.0.1 and node-engine going back to 4.1.0

mhdawson commented 1 month ago

We'll need a bit more details in terms of a recreate. Also the comment about the latest going back to 4.1.0 does not make sense to me as this is what I see in terms of what is tagged for 3.0.1 and it shows 4.1.1 for node-engine/

https://github.com/paketo-buildpacks/nodejs/commit/65d75dbece53dd8be28ef27c87f650c6e8847986

mhdawson commented 1 month ago

Looking at the info for 3.0.1 it also seems to show 4.1.1 - https://github.com/paketo-buildpacks/nodejs/releases/tag/v3.0.1

pbrumm commented 3 weeks ago

I am wondering if it is related to this change.

the ca-certificates jumped from 3.6.7 to 3.8.3

https://github.com/paketo-buildpacks/nodejs/commit/91996d199e37e80ce1299dd39bd2877d7c825ace#diff-ac294531171abf4d8779df7ea98b67560755c4e8329248e8b627624078011f6dL36

here is the diff https://github.com/paketo-buildpacks/ca-certificates/compare/v3.6.7...v3.8.3

pbrumm commented 3 weeks ago

I can't work around this at this point. so I am blocked.

from the looks of it. something is causing nodejs to get added multiple times.

Step #2: Buildpack 'paketo-buildpacks/ca-certificates@3.8.3' already exists on builder with same contents, skipping... Step #2: Buildpack 'paketo-buildpacks/environment-variables@4.7.0' already exists on builder with same contents, skipping... Step #2: Buildpack 'paketo-buildpacks/procfile@5.9.0' already exists on builder with same contents, skipping... Step #2: Buildpack 'paketo-buildpacks/image-labels@4.7.0' already exists on builder with same contents, skipping... Step #2: Buildpack 'paketo-buildpacks/datadog@3.6.0' already exists on builder with same contents, skipping... Step #2: Buildpack 'paketo-buildpacks/node-engine@4.1.1' with same contents is already being added, skipping... Step #2: Buildpack 'paketo-buildpacks/ruby@0.47.0' already exists on builder with same contents, skipping... Step #2: Buildpack 'paketo-buildpacks/ca-certificates@3.8.2' already exists on builder with same contents, skipping... Step #2: Buildpack 'paketo-buildpacks/mri@0.17.6' already exists on builder with same contents, skipping... Step #2: Buildpack 'paketo-buildpacks/node-engine@4.1.0' already exists on builder with same contents, skipping... Step #2: Buildpack 'paketo-buildpacks/puma@0.4.45' already exists on builder with same contents, skipping... Step #2: Buildpack 'paketo-buildpacks/rackup@0.4.44' already exists on builder with same contents, skipping... Step #2: Buildpack 'paketo-buildpacks/bundle-install@0.8.9' already exists on builder with same contents, skipping... Step #2: Buildpack 'paketo-buildpacks/image-labels@4.7.0' already exists on builder with same contents, skipping... Step #2: Buildpack 'paketo-buildpacks/rails-assets@0.10.14' already exists on builder with same contents, skipping... Step #2: Buildpack 'paketo-buildpacks/rake@0.4.44' already exists on builder with same contents, skipping... Step #2: Buildpack 'paketo-buildpacks/unicorn@0.4.44' already exists on builder with same contents, skipping... Step #2: Buildpack 'paketo-buildpacks/yarn@1.3.4' already exists on builder with same contents, skipping... Step #2: Buildpack 'paketo-buildpacks/environment-variables@4.7.0' already exists on builder with same contents, skipping... Step #2: Buildpack 'paketo-buildpacks/thin@0.5.39' already exists on builder with same contents, skipping... Step #2: Buildpack 'paketo-buildpacks/bundler@0.8.14' already exists on builder with same contents, skipping... Step #2: Buildpack 'paketo-buildpacks/passenger@0.14.6' already exists on builder with same contents, skipping... Step #2: Buildpack 'paketo-buildpacks/procfile@5.9.0' already exists on builder with same contents, skipping... Step #2: Buildpack 'paketo-buildpacks/yarn-install@2.0.0' already exists on builder with same contents, skipping... Step #2: Buildpack 'paketo-buildpacks/environment-variables@4.7.0' already exists on builder with same contents, skipping... Step #2: Adding buildpack 'paketo-buildpacks/node-engine@4.1.1' (diffID=sha256:afbe3824c5e262c7477b3e7d10c6aea30fcfc0744eff9a5ed05447d0cb10847d) Step #2: Adding buildpack 'paketo-buildpacks/node-run-script@1.0.19' (diffID=sha256:aefeb9e501b74a1efceddb06a507a46c00a108afe68a9fb6ca90067836cb6613) Step #2: Adding buildpack 'paketo-buildpacks/node-start@2.0.1' (diffID=sha256:809924f48fbfc71a1bcdb7f55722ebb2b0f07e6faba05e464fcf180b82dc5799) Step #2: Adding buildpack 'paketo-buildpacks/nodejs@3.0.1' (diffID=sha256:0e6907834aa6a64a5a4ff47b3b2e775aeb82c71e77fa6cdbe71bc9861f1b6137) Step #2: Adding buildpack 'paketo-buildpacks/npm-install@1.4.3' (diffID=sha256:4f071b74cd1620c9952ccc00dc09e347a34b7a18ee06cf331877be6dcf518727) Step #2: Adding buildpack 'paketo-buildpacks/npm-start@2.0.1' (diffID=sha256:8e6a03bd93a13577753ea7ab5e48f35067b647f5b315a252e19138dbd2cfef35) Step #2: Adding buildpack 'paketo-buildpacks/watchexec@3.2.1' (diffID=sha256:3dd778bef8c93f324048b06c13dadda101e64e7688976a408d39b8bd284f8219) Step #2: Adding buildpack 'paketo-buildpacks/yarn-install@2.0.1' (diffID=sha256:d26190118848b6866eab4c00c4dbf30fcda95fa181d344eaf683f9baa3ad709d) Step #2: Adding buildpack 'paketo-buildpacks/yarn-start@2.0.1' (diffID=sha256:5566626bed91bf0ce2e644e6af797fe9f85dc33cdb8b82bb47843ac24e9b090c) Step #2: Adding buildpack 'paketo-buildpacks/yarn@1.3.5' (diffID=sha256:8d898dc4955c9171307101195f1f60b9b3e57b0377a1149aca8b7911fcd01c16) Step #2: Provided Environment Variables

and before it identifies the active buildpacks it bombs out.

mhdawson commented 3 weeks ago

We'll need a bit more details in terms of a recreate.

pbrumm commented 3 weeks ago

This is a very basic rails 7 project that is just using the default settings and is using node and yarn to compile the assets

after the updates above it is now including many more buildpacks than needed and hits the docker limit.

Another client of mine is experiencing the same issue. I can try to create a simple rails example but it may be a bit before I can get it ready.