Use more shared functions in libnodejs - Githubissues

paketo-buildpacks / npm-install

A Cloud Native Buildpack for npm

Apache License 2.0

10 stars 17 forks source link

Use more shared functions in libnodejs #522

Closed mhdawson closed 1 year ago

mhdawson commented 1 year ago

Summary

use shared funcs to get version from package.json - landed in - https://github.com/paketo-buildpacks/libnodejs/pull/10
use shared function in libnodejs to get project path - landed in - https://github.com/paketo-buildpacks/libnodejs/pull/1

Use Cases

use shared functions instead of local duplicates

Checklist

[X] I have viewed, signed, and submitted the Contributor License Agreement.
[X] I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
[X] I have added an integration test, if necessary.
[X] I have reviewed the styleguide for guidance on my code quality.
[X] I'm happy with the commit history on this PR (I have rebased/squashed as needed).