paketo-buildpacks / npm-install

A Cloud Native Buildpack for npm
Apache License 2.0
10 stars 17 forks source link

Adding ubi-buildpackless-base builder on integration tests #579

Closed pacostas closed 9 months ago

pacostas commented 1 year ago

Merge after

Use Cases

Ensures that ubi-nodejs-extension and UBI images, cooperate with npm-install.

Checklist

mhdawson commented 11 months ago

@pacostas I think we can probably remove a bunch of the files under the node-addon-api directory under node_modules for the native test. I know the ones you have are all installed but I think the files like the .md files are definitely not necessary for the test and it's probably better not to add them to the repo here. I would remove all of the non-functional files under the node-addon-api directory as that will reduce the number of new files being added significantly.

pacostas commented 11 months ago

Removed unnecessary files and also squashed the commits

pacostas commented 11 months ago

rebased.

pacostas commented 10 months ago

@thitch97 I see that on ubi-nodejs-extension the latest release is on November 22 and the PR which is prerequisite for the tests to pass, merged on Dec 6. Can you cut a new release on ubi-nodejs-extension

pacostas commented 9 months ago

@thitch97 Thanks for the new release, can you re-run the tests, probably everything should be working fine.