Fix fpm include custom configs

paketo-buildpacks / php-web

Apache License 2.0

6 stars 7 forks source link

Fix fpm include custom configs #227

Closed Oscar3170 closed 2 years ago

Oscar3170 commented 2 years ago

Summary

Fixes #205 and adds an integration test for custom fpm configs

Use Cases

Overriding the fpm maximum number of child processes

Checklist

[X] I have viewed, signed, and submitted the Contributor License Agreement.
[X] I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
[X] I have added an integration test, if necessary.
[X] I have reviewed the styleguide for guidance on my code quality.
[X] I'm happy with the commit history on this PR (I have rebased/squashed as needed).

thitch97 commented 2 years ago

Hi @Oscar3170, thank you for contributing to the buildpack! We're currently in the middle of restructuring the PHP buildpacks (including this one), so please bear with us as we figure out the best way to incorporate these changes. We acknowledge the workarounds for this issue aren't ideal and will prioritize this work accordingly.

sophiewigmore commented 2 years ago

Hi @Oscar3170 @thitch97! I am working on said restructure work. Confirmed that this will be incorporated into the new buildpack.

sophiewigmore commented 2 years ago

@Oscar3170 sorry for the delay, but this change has been propagated to the new PHP FPM buildpack. It's available for usage in the PHP Language family buildpack v1.1.0. I am closing out this PR for that reason. Thanks again for your original contribution!