search

paketo-buildpacks / php-web

Apache License 2.0
6 stars 7 forks source link

Make ProxyTimeout configurable for HTTPD & PHP-FPM #4

Open dmikusa opened 4 years ago

dmikusa commented 4 years ago

The HTTPD configuration that is generated by this cnb configures a default timeout of 60s.

https://github.com/cloudfoundry/php-web-cnb/blob/master/config/httpd.go#L99

If you have PHP processes that run longer than 60s, you will get a timeout because HTTPD will give up and stop waiting on PHP-FPM to return an answer.

This was a known issue with the php-buildpack, https://github.com/cloudfoundry/php-buildpack/issues/212#issuecomment-396211189

In that case with Cloud Foundry, we could configure a fixed timeout because we knew what Gorouter had configured for a timeout. For the CNBs, they can run in many places and behind many different LBs. It would make more sense to have a ProxyTimeout set in the configuration and allow it to be configurable through buildpack.yml.

cf-gitbot commented 4 years ago

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/172146961

The labels on this github issue will be updated when the story is started.

kvedurmu commented 3 years ago

Related issue (for use case in cloud foundry) - https://github.com/cloudfoundry/php-buildpack/issues/372

fg-j commented 2 years ago

@dmikusa-pivotal Checking in since this issue has been around for a while. Do you still see this as a needed feature?