feat: Adding support for poetry 1.8.0 - 1.8.2

paketo-buildpacks / poetry

Apache License 2.0

5 stars 6 forks source link

feat: Adding support for poetry 1.8.0 - 1.8.2 #377

Closed radoshi closed 6 months ago

radoshi commented 7 months ago

Summary

Fixes #371 This PR adds support for poetry versions 1.8.0, 1.8.1, and 1.8.2.

Use Cases

See summary.

I do not believe an integration test is necessary. Please feel free to guide me if this is incorrect.

Checklist

[x] I have viewed, signed, and submitted the Contributor License Agreement.
[x] I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
[x] I have added an integration test, if necessary.
[x] I have reviewed the styleguide for guidance on my code quality.
[x] I'm happy with the commit history on this PR (I have rebased/squashed as needed).

radoshi commented 7 months ago

Please note: Integration tests are failing locally, both before and after the change. I'm happy to get some guidance on fixing these, but they currently end up timing out.

Unit tests are fine locally.

dmitry-mightydevops commented 6 months ago

can we get attention to this PR and get it approved/merged?

nairb774 commented 6 months ago

@arjun024 Would you be able to help us get traction on this PR?

I wouldn't normally @ someone, but I saw you were recently reviewing PRs for this repo, and thought you might be able to help out with getting traction on this version update. Thanks!

arjun024 commented 6 months ago

@radoshi Thank you for the PR, and sorry we couldn't respond sooner. I have instead merged #389 that includes the latest (1.8.3) and keeps it 2 patches per version line as is convention, as well as remove the 1.6 line. I'll release the buildpack and a python composite buildpack with the latest poetry versions as soon as this goes through the CI. Thanks again

arjun024 commented 6 months ago

https://github.com/paketo-buildpacks/python/releases/tag/v2.19.0