Add dependency mapping RFC addendum

paketo-buildpacks / rfcs

Apache License 2.0

19 stars 33 forks source link

Add dependency mapping RFC addendum #261

Closed sophiewigmore closed 2 years ago

sophiewigmore commented 2 years ago

Summary

Use Cases

Checklist

[X] I have viewed, signed, and submitted the Contributor License Agreement.
[X] I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
[X] I have added an integration test, if necessary.
[X] I have reviewed the styleguide for guidance on my code quality.
[X] I'm happy with the commit history on this PR (I have rebased/squashed as needed).

ryanmoran commented 2 years ago

I don't think this needs to be its own file. I think you can modify the existing RFC with this addendum content. Should make it easier to find.

ryanmoran commented 2 years ago

Should the addendum show that the old format is still supported? We don't mean to make the original SHA256-only format non-functional with this change, right?

sophiewigmore commented 2 years ago

That's what this line is meant to explain:

The dependency mapping implementation in the project will continue to support the use of a sha256 as long as the sha256 buildpack.toml field is supported; however, users of this feature should ideally use a checksum.

I can make this clearer though with an example.

davidmirror-ops commented 2 years ago

WG 11-15-2022: OK to merge